Conversation
Contributor
sehwan505
commented
Nov 19, 2025
sehwan505
commented
- engine 삭제
- adapter 직접 연결
- gpt-4o로 전환
…ocumentation and codebase
There was a problem hiding this comment.
Pull Request Overview
This PR implements a significant architectural refactoring that removes the engine abstraction layer in favor of direct adapter usage. The changes include deleting the entire internal/engine package (pattern, length, style, ast, typechecker, llm engines), simplifying the adapter registry to use tool names directly, and switching the default LLM model from gpt-4o-mini to gpt-4o.
Key Changes:
- Removed engine abstraction layer and connected validators directly to adapters
- Simplified adapter registry from language+category lookup to simple tool name lookup
- Changed default LLM model from gpt-4o-mini to gpt-4o across the codebase
- Removed
GenerateConfigmethod from adapter interface - Added new
cmd/test-adapterCLI tool for testing adapters
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/*.go | Deleted 5 integration test files for engines (validator_policy_test.go, typechecker_integration_test.go, style_integration_test.go, pattern_integration_test.go, length_integration_test.go, ast_integration_test.go) |
| tests/integration/helper.go | Removed getToolsDir helper function |
| tests/e2e/*.go | Updated model from gpt-4o-mini to gpt-4o, fixed formatting (tabs→spaces) |
| internal/validator/validator.go | Major refactor: removed engine dependency, added direct adapter usage with new Violation fields (RawOutput, RawError, ToolName, ExecutionMs) |
| internal/mcp/server.go | Updated model to gpt-4o, formatting fix |
| internal/llm/client.go | Changed defaultModel constant from gpt-4o-mini to gpt-4o |
| internal/engine/* | Deleted entire engine package (core, registry, pattern, length, style, ast, typechecker, llm) |
| internal/converter/converter.go | Added special LLM validator handling with default selector and desc validation |
| internal/cmd/*.go | Updated default model flags from gpt-4o-mini to gpt-4o |
| internal/adapter/registry/*.go | Simplified registry from language+category to tool name lookup |
| internal/adapter//.go | Removed GenerateConfig method, cleaned up tests, fixed defer patterns |
| internal/adapter/adapter.go | Removed GenerateConfig from interface |
| docs/*.md | Updated documentation to reflect gpt-4o as default |
| cmd/test-adapter/main.go | New CLI tool for testing adapters directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.